| ??? 04/07/06 12:52 Read: times |
#113813 - It could do with some improvement! Responding to: ???'s previous message |
Don't hold back Erik! Yeh, sure the code is a not shining example of computer science, but it probably works - not that I could figure it out without much mental gymnastics. I've written code like that before, you come back to it 3 months later and try to figure it out! What I think is interesting is putting the repeat code into the ISR - the key won't be repeating at anywhere near 500uS! Why not just have the ISR read and debounce the keys and have another task running at a more reasonable rate take care of the repeat feature? For a user interface, updating things at 100mS is a little fast, somewhere around 300-500mS is probably more user friendly. |
| Topic | Author | Date |
| LCD repeat function in C | 01/01/70 00:00 | |
| First thought | 01/01/70 00:00 | |
| if its roundrobin | 01/01/70 00:00 | |
| last post | 01/01/70 00:00 | |
| Sounds fine | 01/01/70 00:00 | |
| the one issue | 01/01/70 00:00 | |
| stuck key | 01/01/70 00:00 | |
| Yes | 01/01/70 00:00 | |
| Code Review | 01/01/70 00:00 | |
| this must be excellent switches | 01/01/70 00:00 | |
excellent debounce for bad switches | 01/01/70 00:00 | |
| better code version | 01/01/70 00:00 | |
| no comments, captals, no indenting | 01/01/70 00:00 | |
| It could do with some improvement! | 01/01/70 00:00 | |
| I did not comment on that, it may very w | 01/01/70 00:00 | |
| true.... | 01/01/70 00:00 | |
| led to so much misinformation in this fo | 01/01/70 00:00 |