| ??? 03/01/10 10:32 Read: times |
#173677 - Yes, it's wrong - but... Responding to: ???'s previous message |
Kai Busuttil said:
//if user inputted password is not equal to the saved password then it's incorrect
if (password[cnt2] != passINP[cnt2]);
{
flag = 0;
}Obviously (sic) this code snippet is within a for loop in my code. 'passINP' is a char array where I'm storing each keypress the user does on a keypad and 'password' is another char array Neil Kurzman said:
password[cnt2] != passINP[cnt2])
Is comparing the address of the arrays. which in this case are different. Maarten Brock said:
Huh? Why do you assume that? Surely if both password and passINP are char arrays they can be compared this way. That is what the OP said - although he hasn't shown the actual declarations. Assuming the OP has correctly defined them as char arrays (as he said), then the comparison is correct. Maarten said:
It might even result in smaller code size. I think it's rather unlikely that a manually-coded 'C' for loop is going to be much (if any) better than the compiler's own library function? |
| Topic | Author | Date |
| Question about KEIL | 01/01/70 00:00 | |
| It ain't how i would do it | 01/01/70 00:00 | |
| Thank you! | 01/01/70 00:00 | |
| using strncmp for a password check is a bug :^) | 01/01/70 00:00 | |
| Yeah whatever | 01/01/70 00:00 | |
| Interesting | 01/01/70 00:00 | |
| Eh?? | 01/01/70 00:00 | |
40 instead of 50000000 | 01/01/70 00:00 | |
| Nothing to do with Keil | 01/01/70 00:00 | |
| Hmmm I see | 01/01/70 00:00 | |
| Problem solved! | 01/01/70 00:00 | |
| Do you undrestand why it did not work? | 01/01/70 00:00 | |
| Wrong | 01/01/70 00:00 | |
| Yes, it's wrong - but... | 01/01/70 00:00 | |
| code size decrease | 01/01/70 00:00 | |
| Maybe | 01/01/70 00:00 | |
| After a nights sleep | 01/01/70 00:00 | |
| Where it gets specific to Keil (or whatever) | 01/01/70 00:00 | |
| Explain | 01/01/70 00:00 | |
| Woops. | 01/01/70 00:00 | |
| such a 'newb' error (sic) | 01/01/70 00:00 | |
| Password application | 01/01/70 00:00 |