Let say i want to drrive a 7-segement display viz controller...

firstly for hardware i need to use buffer as controller has 3mA and 7-segment neededs more than this so using 74LS343..

Now check the code and tell me is there any if not easier efficient way of writing code to drive 7-segment display .. the final objective is digital Clock..

MOV A,P2
ANL A,#0FH
Zero: CJNE A,#00H,ONE
MOV P1, #00111111 B
( this binary represents h,g,f,e,d,c,b,a)
Now to make zero from 7-segment we have to shut off the LED "g" and "h" that;s why using the above code.

ONE: CJNE A,#01H,TWO
MOV P1, #00000110 B ( to make 1)

Is this ok or for clock should i use some other technqiue.