I have some code listed below that I believe is inefficient, or written strangely. Even if "mystring" is declared as an xdata item, why is the code in the function using local variables declared as xdata? Can anybody revise this code to make it more efficient? Thanks in advance.

typedef struct struct_string_tag
{
unsigned char size; // current number of elements used
unsigned char val[21]; // storage area
} mystring;

mystring xdata s;

long value(mystring *s)
{
int xdata i;
long xdata result=0; // holds the accumulated result

for (i=0; i<(x->size); i++)
{
result <<= 8; // shift the accumulated result
result += x->val[i]; // add the next byte
}

return result;
}