Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
06/28/04 09:19
Read: times


 
Msg Score: +1
 +1 Good Question
#73253 - Assemble coding style
I was looking at an Intel application note (AP-410 Enhanced Serial Port on the 83C51FA) and came across this snippet.


RECEIVE DATA:
JNB RI, $ ; Wait for RI to be set
MOV C, SCON.7 ; Check for framing error
JC FRAMING ERROR
MOV TEMP, SBUF ; Receive data byte & store
; in temporary location
CLR RI ; Clear flag for next
; reception
SETB SM2 ; Re-enable Automatic
; Addressing
POP PSW
RETI

My question is, in these lines

MOV C, SCON.7 ; Check for framing error
JC FRAMING ERROR

why not just use

JB SCON.7, FRAMING ERROR

That seems clearer / more (or at least as) efficient to me. Is it just coding style, or is there something I'm missing - I am a newb after all!

List of 7 messages in thread
TopicAuthorDate
Assemble coding style            01/01/70 00:00      
   RE: Assembler coding style            01/01/70 00:00      
   RE: Assemble coding style            01/01/70 00:00      
   RE: Assemble coding style            01/01/70 00:00      
   RE: Assemble coding style            01/01/70 00:00      
   RE: Assemble coding style            01/01/70 00:00      
      RE: Assemble coding style            01/01/70 00:00      

Back to Subject List