Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
09/14/06 11:01
Modified:
  09/14/06 11:04

Read: times


 
#124285 - Persistance my friend
Responding to: ???'s previous message
Arvind, your comments are supposed to tell us what we don't know!

[pre]
acall DELAY ; calls the 30 MS delay subroutine
mov a, p1 ; mov the value of p1 to acc
push acc ; value of acc is preserved
anl a, #0fh ; higher nibble is made low ie ROW
cjne a, #0fh, AHEAD ;if the Lower Nibble ie Coulmn reading is not high then
; it means any column has been pressed
; jump to subroutine AHEAD
sjmp SCAN_MATRIX_KEYBOARD ; otherwise LOOP
[/pre]

Your comments are meant to explain the basic logic of what the code is doing not reword what the instruction is. I think Jan and me would've preferred you try to rewrite your code with the hints we gave you. Please don't expect us to rewrite your code - you won't learn anything. A Jan mentions - its all bad! You've got the basic concept, but the execution is flawed. Try writing code to decode just one row and use the LCD to output the results - once you have that going, then try all four. Break the problem down and you'll solve it in less time it took to post this message and wait for responses. A little persistance goes a long way. I see you didn't solve the problem for the 4bit LCD.


List of 27 messages in thread
TopicAuthorDate
Matrix Keyboard not working            01/01/70 00:00      
   the logic            01/01/70 00:00      
   Lots of problems            01/01/70 00:00      
      no, it's completely bad in concept            01/01/70 00:00      
      Does the LCD Work?            01/01/70 00:00      
      enphasizing            01/01/70 00:00      
   commented code            01/01/70 00:00      
      Persistance my friend            01/01/70 00:00      
         I'll try it in other way            01/01/70 00:00      
            I'll make the corrections            01/01/70 00:00      
      Note on comments            01/01/70 00:00      
         bad, very bad - yes, but not necessarily because            01/01/70 00:00      
            Subroutine Details            01/01/70 00:00      
               I don't know            01/01/70 00:00      
                I do not know what that information is good for.            01/01/70 00:00      
                  Column scan after ROW confirmation            01/01/70 00:00      
                     Maybe the problem is not here            01/01/70 00:00      
      more Informative code            01/01/70 00:00      
         Comments are better            01/01/70 00:00      
         The Algorithm            01/01/70 00:00      
            This isn\'t necessarily true ...            01/01/70 00:00      
               a correct pain in the gluteus maximus            01/01/70 00:00      
                  Why so much pain?            01/01/70 00:00      
               An exercise for the student            01/01/70 00:00      
               everyone else            01/01/70 00:00      
   Does the LCD Work?            01/01/70 00:00      
      LCD is fine            01/01/70 00:00      

Back to Subject List