Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
02/25/08 13:53
Read: times


 
#151404 - A bit easier to read?
Responding to: ???'s previous message
A little whitespace goes a long way:
#include <reg52.h>

#define MAX_LINES          3
#define MAXCHARS_ON_LINE   10
#define CHAR_MASK          0xBF
#define high 1        
#define low  0        

sbit clear = P3^0;    
sbit write = P3^1;    

#define uint unsigned int
#define uchar unsigned char

void msec(uint x) 
    { uchar j;
      while (x-->0)
        { for(j=0;j<125;j++);
        }
    }

void code clear_display() 
    { clear=high;
      clear=low;
      clear=high;}

void code write_enable() 
    {write=high;
     write=low;
     write=high;}

void code word_delay()
    {msec(3500);}

unsigned char code *phrases2[] = {
  "Short",   "Medium",  "Very long"   };

void put_phrase( unsigned char line_no )  
{   
    while (*phrases2[line_no] != 0x00) 
    {  
       P0 = *phrases2[line_no];	
	    ++phrases2[line_no];
            write_enable();
    }
}

void main( void )            
{  
   clear_display();
   for(;;)                   
   {  
      unsigned char line_no;
      for ( line_no = 0; line_no < MAX_LINES; line_no++ )
      {
          put_phrase( line_no );
          word_delay();
          clear_display();
      }
   }
}

Still requires MAX_LINES to be manually updated - see:
http://www.8052.com/forum/read.phtml?id=151340
http://www.8052.com/forum/read.phtml?id=151341

And there's the issue of phrase lengths - see:
http://www.8052.com/forum/read.phtml?id=151327



Still needs some consistency in the placing of the braces...

List of 54 messages in thread
TopicAuthorDate
Best way to consolidate....out of memory            01/01/70 00:00      
   isn't this the classical gotcha?            01/01/70 00:00      
   There was a hint here....            01/01/70 00:00      
      Not const            01/01/70 00:00      
         Not necessarily            01/01/70 00:00      
            Hmmm...            01/01/70 00:00      
               Hmmm, indeed            01/01/70 00:00      
               Why?            01/01/70 00:00      
                  One reason ... and the prolly the original intent            01/01/70 00:00      
                     Obviously            01/01/70 00:00      
                        Speed            01/01/70 00:00      
                           Rogue programs?            01/01/70 00:00      
                              Yes. And stupid programmers            01/01/70 00:00      
                                 True            01/01/70 00:00      
                           cases            01/01/70 00:00      
                        The Obvious...            01/01/70 00:00      
                           Fair enough            01/01/70 00:00      
                              make sure the developer doesn't do something stupi            01/01/70 00:00      
                              Const to Code EPROM or FLASH,,,            01/01/70 00:00      
                           const and volatile - for optimization            01/01/70 00:00      
                  consts in other than CODE space            01/01/70 00:00      
                     Use the extended keywords            01/01/70 00:00      
                        'const' and 'volatile'            01/01/70 00:00      
   Unreadable code!            01/01/70 00:00      
      It really was all Keils fault....;)            01/01/70 00:00      
   You don't want to start from here!            01/01/70 00:00      
      Previously, on 8052.com...            01/01/70 00:00      
      Array of string            01/01/70 00:00      
         Yes, my mistake            01/01/70 00:00      
   string concatenate            01/01/70 00:00      
      Comments            01/01/70 00:00      
         Wow......LOL            01/01/70 00:00      
            Not a C vs ASM thing            01/01/70 00:00      
               From your perspective, it may make sense            01/01/70 00:00      
      I went this direction....code padding removal?            01/01/70 00:00      
         For but one byte added to the array...            01/01/70 00:00      
         With proper ordering in source file...            01/01/70 00:00      
         Putting it all together            01/01/70 00:00      
            Spectacular Russ.....            01/01/70 00:00      
   THINK            01/01/70 00:00      
      that is surely needed            01/01/70 00:00      
      A bit easier to read?            01/01/70 00:00      
         easy to read???            01/01/70 00:00      
      typedef vs #define            01/01/70 00:00      
      I think not            01/01/70 00:00      
         Tks Russ.            01/01/70 00:00      
            THINK(ing)            01/01/70 00:00      
               ???            01/01/70 00:00      
                  Objectives.            01/01/70 00:00      
                     I beg your pardon?!            01/01/70 00:00      
                     I see            01/01/70 00:00      
   Best way to consolidate....out of memory            01/01/70 00:00      
   Why specify CODE for functions?            01/01/70 00:00      
      there is so much stuff            01/01/70 00:00      

Back to Subject List