Whilst it's always good to get a second opinion - does your program have a problem?

Is your code structured? The simplest way of explaining this is could it be described in 'c' easily?

Is it modular? Can critical modules be tested independantly?

With little micros, most people have a tendancy to write tight, cryptic code. Whilst this is sometimes necessary to fit in the memory constraints of the micro in question, for code above 2k it gets hard to maintain. Many micros have quite a lot of ram and rom so the requirment to squeeze as much as you can in is less of an issue, also most people will use 'c' to write the program.

You may wish to read a book called 'Code Complete' from Microsoft Press. It is a easy read and should give you many hints on how to construct your code.

Also, everyone has a different opinion on what is 'good' coding practice. Personally I like to write simple code and if I need to gain some speed or size then I start using 'dirty' tricks. Show your code to 10 people and you'll get some conflicting opinions. If you needed to add a substancial feature to your program, would it be relatively easy, or would you need to rewrite your code? The end use of the program also dictates how much effort you put into it - a few hundred lines for a hobby robot you can get away with being fairly lazy whereas if it was for a fuel injection system that would be made by the 100,000's and HAS to work then you would be more stringent.

You can send me your code for my critique if you wish. It would be worthwhile sharing the feedback you get and compile a top ten code in bad code! We've all written bad code at some stage and hopefully we learn from it!!

Rule#1 of programming - get the code to work, then optimise it!