Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
05/17/07 11:25
Read: times


 
#139429 - Style
Responding to: ???'s previous message
Denis B said:
void keypad_read(void)
{
unsigned char keypad_scan;
    key = ((keypad_scan=keypad_address)&keypad_mask);
  	key_lcd = key_table[key];
}

Style is, of course, a matter of personal preference, but there are some elements of style that can bring objective benefits.

The style of cramming as much as possible into a single line has a couple of disadvantages:

  • It's harder to read;

  • It's harder to debug;

    and it almost certainly gives no advantage in the generated code.

    Therefore I would prefer to write it as:
    void keypad_read(void)
    {
        unsigned char keypad_scan;
    
        keypad_scan = keypad_address;
        key         = keypad_scan & keypad_mask;
        key_lcd     = key_table[key];
    }
    

    Note also that increasing the indent level is conventionally used to indicate that the indented line is somehow "subordinate".
    There is no such "subordination" in the above code, so the lines all have the same indent level.

    Again, this is a lot to do with personal preferences; it's not that your style is "bad" - just that I think (subjective) that it could be "better"



  • List of 29 messages in thread
    TopicAuthorDate
    writing to XDATA with KEYPAD and displaing on LCD            01/01/70 00:00      
       One step at a time            01/01/70 00:00      
          please..., see good my question...            01/01/70 00:00      
          let\'s make the guesswork, then...            01/01/70 00:00      
             yes..            01/01/70 00:00      
                So where's the problem?            01/01/70 00:00      
                   how?            01/01/70 00:00      
                      Links            01/01/70 00:00      
                         i am using a KEIL            01/01/70 00:00      
                            So you're sorted, then!            01/01/70 00:00      
                               .... ok .... but ......            01/01/70 00:00      
                                  relevant            01/01/70 00:00      
                                     What is the "working" code?            01/01/70 00:00      
                                        this code is working in my 89c51rd2            01/01/70 00:00      
                                           so do something like...            01/01/70 00:00      
                                              here is a question !!!!            01/01/70 00:00      
                                                 Style            01/01/70 00:00      
                                                    this is far from...            01/01/70 00:00      
                                                       Style vs Substance            01/01/70 00:00      
                                                          OK I take that one back...            01/01/70 00:00      
                                                             Language-Independent            01/01/70 00:00      
             Here is a typical problem caused by HLL use            01/01/70 00:00      
                When the only tool you have is a hammer            01/01/70 00:00      
                   yes, registers mapped into XDATA space ......            01/01/70 00:00      
                   Then the entire world looks like a nail ...            01/01/70 00:00      
       XDATA Addresses            01/01/70 00:00      
          u r right..            01/01/70 00:00      
             Fair enough, but...            01/01/70 00:00      
                :-)) u r right...            01/01/70 00:00      

    Back to Subject List