Email: Password: Remember Me | Create Account (Free)

Back to Subject List

Old thread has been locked -- no new posts accepted in this thread
???
05/17/07 13:27
Read: times


 		 #139435 - Style vs Substance
Responding to: ???'s previous message
Jan Waclawek said:
I don't think it is the best idea to call a function from an ISR ... but's that's more on style than function as well.

Not really.

There are very good operational reasons why it is generally not a good idea to call a function from an ISR: get this one wrong, and it will impact the performance of your system - possibly to the point of not working at all!

Purely "style" issues like indenting, cramming everything on one line, use of upper/lower case, position of braces, use of "redundant" braces, precisely meaningful names, etc, etc, have no effect whatsoever on the compiler's output and, therefore, the system operation.


List of 29 messages in thread
TopicAuthorDate
writing to XDATA with KEYPAD and displaing on LCD            01/01/70 00:00      
   One step at a time            01/01/70 00:00      
      please..., see good my question...            01/01/70 00:00      
      let\'s make the guesswork, then...            01/01/70 00:00      
         yes..            01/01/70 00:00      
            So where's the problem?            01/01/70 00:00      
               how?            01/01/70 00:00      
                  Links            01/01/70 00:00      
                     i am using a KEIL            01/01/70 00:00      
                        So you're sorted, then!            01/01/70 00:00      
                           .... ok .... but ......            01/01/70 00:00      
                              relevant            01/01/70 00:00      
                                 What is the "working" code?            01/01/70 00:00      
                                    this code is working in my 89c51rd2            01/01/70 00:00      
                                       so do something like...            01/01/70 00:00      
                                          here is a question !!!!            01/01/70 00:00      
                                             Style            01/01/70 00:00      
                                                this is far from...            01/01/70 00:00      
                                                   Style vs Substance            01/01/70 00:00      
                                                      OK I take that one back...            01/01/70 00:00      
                                                         Language-Independent            01/01/70 00:00      
         Here is a typical problem caused by HLL use            01/01/70 00:00      
            When the only tool you have is a hammer            01/01/70 00:00      
               yes, registers mapped into XDATA space ......            01/01/70 00:00      
               Then the entire world looks like a nail ...            01/01/70 00:00      
   XDATA Addresses            01/01/70 00:00      
      u r right..            01/01/70 00:00      
         Fair enough, but...            01/01/70 00:00      
            :-)) u r right...            01/01/70 00:00      

Back to Subject List