| ??? 09/09/06 00:29 Read: times |
#123953 - so, use structures! Responding to: ???'s previous message |
Mark Buster said:
Regarding the "magic numbers", The reason I did it this way is that this chunk of code is just one of multiple serial frame handlers, which all have a LEN,TYPE,CMD, etc, which will be different values within the different handlers, therefore a #define is not going to work for this situation. A structure's the thing! reconsider Andy Neil's example: typedef struct _frame_tp
{
unsigned char length;
unsigned char type;
unsigned char cmd;
unsigned char node
} frame_tp;
-a |
| Topic | Author | Date |
| ^= , Checksum, Problem | 01/01/70 00:00 | |
| Have you tried a simulator? | 01/01/70 00:00 | |
| well, | 01/01/70 00:00 | |
| OK | 01/01/70 00:00 | |
| volatile? | 01/01/70 00:00 | |
| volatile | 01/01/70 00:00 | |
| using ICE ? | 01/01/70 00:00 | |
| update code (working) and clarification | 01/01/70 00:00 | |
| Style | 01/01/70 00:00 | |
| Think about your variable types | 01/01/70 00:00 | |
| Thanks | 01/01/70 00:00 | |
| Magic numbers | 01/01/70 00:00 | |
| but don't be "oversmart" | 01/01/70 00:00 | |
| example? | 01/01/70 00:00 | |
| advantages | 01/01/70 00:00 | |
the most often forgotten quality guarantee | 01/01/70 00:00 | |
| so, use structures! | 01/01/70 00:00 | |
| padding | 01/01/70 00:00 | |
| | 01/01/70 00:00 | |
| Actual Output | 01/01/70 00:00 | |
| C99 | 01/01/70 00:00 | |
| making up your own | 01/01/70 00:00 | |
| Names | 01/01/70 00:00 | |
| FYI - C99 Exact- & Minimum-width types | 01/01/70 00:00 |