??? 04/13/07 12:15 Read: times |
#137146 - Joe, please read this Responding to: ???'s previous message |
Joe, you, almost jubilantly, post: "it's functioning"
and Patrick show that while that may be so, there are serious problems I don't think it's a good idea to initalise your display in an interrupt routine. The same applies to calling the display routine from your ISR. My comment "I know it's not a good idea" and, I, honestly, believe that Patrick means the same, he is just not as 'brutal' as yours truly. Joe, the fact that "it's functioning" does not mean that it is right. Do not let yourself get suckered into believing that because it 'works' you are done. If you add anything serious to the main loop, what you have will fall apart. I can tell you, with some certainty, that if you increase the baudrate, your code will fail. Now, you may say "I have no intention of adding anything serious to the main loop, or increasing the baudrate, so what is the beef?". If you do not develop good design practices with this (your first?) project before you move on, you may later find that you have developed some habits that will be almost impossible to get rid of. I am mainly refering to the "it works" instead of "it's right". Countless 'developers' have 'developed' something that 'worked' and been at a total loss when it stopped wqrking because something completely unrelated was added. do implement KISS (Keep Isrs Short and Simple) before you move on. Erik |
Topic | Author | Date |
RxD to LCD problems | 01/01/70 00:00 | |
Serial ISR | 01/01/70 00:00 | |
work needed. | 01/01/70 00:00 | |
you need to control flow | 01/01/70 00:00 | |
confused | 01/01/70 00:00 | |
this is what I mean | 01/01/70 00:00 | |
OK | 01/01/70 00:00 | |
yes | 01/01/70 00:00 | |
Non-useful Serial ISR | 01/01/70 00:00 | |
AND it's stuck | 01/01/70 00:00 | |
thanks | 01/01/70 00:00 | |
I was going for optimization. | 01/01/70 00:00 | |
It's functioning | 01/01/70 00:00 | |
now stay consistent | 01/01/70 00:00 | |
Terminating code? | 01/01/70 00:00 | |
. | 01/01/70 00:00 | |
correct terminology | 01/01/70 00:00 | |
Missing the point | 01/01/70 00:00 | |
i get it now | 01/01/70 00:00 | |
Most, but not all | 01/01/70 00:00 | |
why on earth | 01/01/70 00:00 | |
if it\'s almost correct, it\'s still wrong :-) | 01/01/70 00:00 | |
ok | 01/01/70 00:00 | |
Not R6 and R7 | 01/01/70 00:00 | |
well it happend again | 01/01/70 00:00 | |
Q.E.D. | 01/01/70 00:00 | |
One further comment is needed | 01/01/70 00:00 | |
Hey | 01/01/70 00:00 | |
Dangerous recommendation | 01/01/70 00:00 | |
good point | 01/01/70 00:00 | |
they all do![]() | 01/01/70 00:00 | |
it 'trust' the same as 'experiment'? | 01/01/70 00:00 | |
more issues | 01/01/70 00:00 | |
Joe, please read this | 01/01/70 00:00 |