If hardware knowledge is important for embedded programming, so is software (knowledge of proper software design and implementation). I am constantly impressed by Keil and I try to use classic C programming techniques wherever I can (that is, except where necessary my code would look pretty similar on any target platform). I think it's important to understand the philosphies behind C and to a lesser extent C++ in order to write excellent code. If you are a self-taught C programmer then I urge you to take a class or two (say, at a university night class maybe?). Unfortunately it's equally important that the class instructor is versed in these philosophies and that can be hard to determine. :-( I started in hardware as an EE and later I was "reprogrammed" in software. It really opened my eyes.

Anyway, back to the original post, ... perhaps show us some code and we can comment on it. Keil has a lot to offer when used properly.

GB