??? 08/27/06 11:55 Modified: 08/27/06 12:04 Read: times |
#123133 - \"It works\" Responding to: ???'s previous message |
Ashwin, apart from stating 'it works' - does it comply with the Hitachi datasheet? This answers any argument and removes personal judgement. Can you say your code complies with the Hitachi( or applicable) datasheet?
I've written a lot of stuff 'that worked' then failed when something changed - different brand, differnet batch etc. Only when it complies with the datasheet can you be reasonably confident you have done everything in your power to make sure it works. I just had a quick look at your code in the library: 1/the initialisation doesn't seem to follow the hitachi datasheet for 4 bit initialisation 2/ You allow plenty of setup time (8 NOPS) which is unecessary for a 12 clock cpu @11.0592MHz. Sure, it is conservative, but the other critical time is the EN high time that one would expect would have some NOPs also to cope with higher speed cpus. I posted some code in another recent discussion of the 4bit mode - there's no comments so that (hopefully) the person using it will refer to the hitachi datasheet and it will explain what is happening. |